Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503256 --- Comment #34 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-06-07 05:40:20 EDT --- MUST: The spec file for the package is legible and macros are used consistently. NEEDSWORK - %install phase needs comments and can be cleaned up, see above. MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. NEEDSWORK - License is LGPLv2+ not LGPLv3. (see source code headers) MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. NA MUST: Optflags are used and time stamps preserved. OK MUST: Packages containing shared library files must call ldconfig. OK MUST: A package must own all directories that it creates or require the package that owns the directory. NEEDSWORK - The current contents of the %doc package %{_datadir}/doc/gtkmm-utils/html is not OK since a) nothing would own %{_datadir}/doc/gtkmm-utils/ b) the packages would have different documentation directories. Listing files as %doc puts them into %{_datadir}/doc/%{name}-%{version}. You will need to rm -rf {_datadir}/doc/gtkmm-utils at the end of the install phase and just list the documentation as %doc docs/html/* Get rid of the -doc package and put this in -devel since it's small in size. MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. NEEDSWORK - Documentation is not large, I wouldn't put it in -doc. MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. NEEDSWORK - Drop HACKING, it's not relevant. MUST: Header files must be in a -devel package. OK MUST: Static libraries must be in a -static package. N/A MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. OK MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. OK MUST: Packages does not contain any .la libtool archives. OK MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review