Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503336 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-06-06 14:34:10 EDT --- - Listing locales explicitly is forbidden, you need to use %{find_lang}. http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files - Explicitly requiring stfl, sqlite, libcurl, libxml2 is forbidden, the dependencies will be automatically picked up by rpm. http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires - Is the prefix argument for both make and make install really necessary? - I wouldn't include %{_defaultdocdir}/%{name}/* instead I'd remove that directory after install and list the documentation under %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review