Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495902 --- Comment #15 from Paul Fox <pgf@xxxxxxxxxx> 2009-06-05 12:45:38 EDT --- (In reply to comment #14) > (In reply to comment #13) > > i'm not sure what you mean. are you saying my line breaks shouldn't be there? > > No, you should use the lines up to 80 characters, yours are shorter currently. > oh! sure, i can fix that. :-) > > i think the usefulness of timestamps > > is subverted almost entirely by making it appear as if files are older than > > they actually are. but i'll adapt, i guess. :-) > > timstamps are important for rpm to see if a file has actually changed. This is > especially important on multiarch systems (so not on the XO), where you can > install two versions of a package in parallel. If two files have same size and > date, they will be treated as one file, if they differ, rpm will say they > conflict. okay -- i thought it was just for users. > > > i'll research this. i confess it's a little confusing as the maintainer to be > > doing a release based on a sandbox, rather than on a tarball. can you perhaps > > point me at a (simple) git-based package that does this correctly? a template > > would help me here. > > Version is 6 > Release is 2 (pls increase even during review) > To mark the git checkout: 20090506git > All together it becomes: olpc-kbdshim-6-2.20090506git okay. from now, the package includes the date and git hash (abbreviated). > > > there's no configuration: after installation and a reboot, the following > > things should work: > > - with any grab key pressed, both the touchpad and the arrow keys should > > cause scrolling. on a USB keyboard, the "windows" keys will act as grab > > keys. > > - the rotate and brightness keys should "just work". these keys cause the > > olpc-rotate and olpc-brightness scripts in /usr/bin to be invoked. > > I don't have /usr/bin/olpc-brightness. What package is it from? yikes! good catch. there used to be good reason for olpc-brightness to be packaged with olpc-powerd (unreviewed), but that's no longer the case. since i usually install both packages for testing, i hadn't noticed that olpc-brightness wasn't being installed by olpc-kbdshim. i've fixed this, and now olpc-kbdshim installs both the olpc-rotate and olpc-brightness scripts. please review: http://dev.laptop.org/~pgf/rpms/srpms/olpc-kbdshim.spec-6-2.20090605git98f5b2c http://dev.laptop.org/~pgf/rpms/srpms/olpc-kbdshim-6-2.20090605git98f5b2c.src.rpm and test: http://dev.laptop.org/~pgf/rpms/olpc-kbdshim-6-2.20090605git98f5b2c.fc9.i386.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review