Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478931 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |oget.fedora@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review? Bug 478931 depends on bug 478929, which changed state. Bug 478929 Summary: Review Request: globus-usage - Globus Toolkit - Usage Library https://bugzilla.redhat.com/show_bug.cgi?id=478929 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED Bug 478931 depends on bug 467237, which changed state. Bug 467237 Summary: Review Request: globus-gssapi-gsi - Globus Toolkit - GSSAPI library https://bugzilla.redhat.com/show_bug.cgi?id=467237 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED Bug 478931 depends on bug 478921, which changed state. Bug 478921 Summary: Review Request: globus-io - Globus Toolkit - uniform I/O interface https://bugzilla.redhat.com/show_bug.cgi?id=478921 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED Bug 478931 depends on bug 478930, which changed state. Bug 478930 Summary: Review Request: globus-rls-client - Globus Toolkit - Replica Location Service Client https://bugzilla.redhat.com/show_bug.cgi?id=478930 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED --- Comment #3 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-06-05 01:54:57 EDT --- This one was quite different from the other globus packages. Here is my review: - package builds in koji rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=1394353 ? I don't know if this BuildRequires: globus-gssapi-gsi-devel >= 4 is really required, since $ grep -rl gssapi * pkgdata/pkg_data_src.gpt.in Is it an upstream error or am I missing something? * Afaik %setup is supposed to be used only once in a specfile. So %setup -q -n %{_name}-%{version} %setup -D -T -q -n %{_name}-%{version} -a 1 should be replaced by %setup -q -n %{_name}-%{version} -a 1 ? Actually, why are you not making globus_rls_server_setup a package on its own? ! It would be good to briefly explain what Source{1,2,3} are for where you declare them. * rpmlint complains globus-rls-server.x86_64: E: wrong-script-interpreter /usr/share/globus/setup/SXXrls.in "@SHELL@" globus-rls-server.x86_64: E: non-executable-script /usr/share/globus/setup/SXXrls.in 0644 globus-rls-server.x86_64: E: non-readable /etc/globus-rls-server.conf 0600 globus-rls-server.x86_64: W: no-reload-entry /etc/rc.d/init.d/globus-rls-server Any words for these? ! Please preserve the timestamp of %{SOURCE3} in %install ! There is some html documentation under ./Doc that can be packaged. Also there is an INSTALL.html ! I don't know how serious they are but Doc/man/man8/globus-rls-server.8 Doc/html/globus-rls-server.html server.c contain references to /usr/local. You might want to fix them. ? /usr/share/globus/setup/setup-globus-common.pl defines perl location as /usr/lib/perl/ Will this be a problem? ? Are the tests under ./test worth running in %check ? ! The package owns the directory /usr/share/globus/packages/setup/ I wasn't sure if this is intentional (or if its contents should actually go to /usr/share/globus/packages/globus_rls_server_setup/) and just wanted to bring it into your attention. * The scriplets are different than the ones in the guidelines: http://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets (See the Requires(*) stuff) * %{_initrddir}/%{name} does not contain all the required actions http://fedoraproject.org/wiki/Packaging/SysVInitScript#Required_Actions ? The "status" action in %{_initrddir}/%{name} has the port number hard-coded. Shouldn't the port number be taken from %{_sysconfdir}/%{name}.conf ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review