Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504225 --- Comment #2 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-06-04 18:57:43 EDT --- Builds fine, rpmlint says only: libdlo.x86_64: W: no-documentation libdlo-devel.x86_64: W: no-documentation which would be OK, except that the main package needs the COPYING file and there does seem to be some development documentation in the Guide-v104.pdf file which should probably be in the -devel package. * source files match upstream. sha256sum: 2a3af6e035c03f61dd170514271d81995c31018d13247436a3b8bfc37e2c3da0 libdlo-0.1.0.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. X license text included in tarball but not in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * final provides and requires are sane: libdlo-0.1.0-1.fc11.x86_64.rpm libdlo.so.0()(64bit) libdlo = 0.1.0-1.fc11 libdlo(x86-64) = 0.1.0-1.fc11 = /sbin/ldconfig libdlo.so.0()(64bit) libusb-0.1.so.4()(64bit) libdlo-devel-0.1.0-1.fc11.x86_64.rpm libdlo-devel = 0.1.0-1.fc11 libdlo-devel(x86-64) = 0.1.0-1.fc11 = libdlo = 0.1.0-1.fc11 libdlo.so.0()(64bit) * shared libraries are installed: ldconfig called properly. unversioned .so links are in the -devel package. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * scriptlets are OK (ldconfig). * code, not content. * header is in the -devel package. * no static libraries. * no libtool .la files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review