Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503490 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-06-02 03:22:05 EDT --- 1) can you put complete download url as http://downloads.sourceforge.net/ayttm/ayttm-0.5.0-89.zip 2) exclude .la files also by removing following from %files %{_libdir}/ayttm/*.la 3) can you use desktop-file-install to install desktop files as given at http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage 4) don't add following to %files %{_datadir}/locale/*/LC_MESSAGES/ayttm.mo instead use http://fedoraproject.org/wiki/PackagingGuidelines#Handling_Locale_Files 5) you don't need Requires: gdb Requires: gtk2 >= 2.12.0 Requires: glib2 >= 2.0.0 6) drop versions from BuildRequires: gtk2-devel >= 2.12.0 BuildRequires: glib2-devel >= 2.0.0 7) remove unnecessary things from SPEC like # If you want stripped RPM with no crash dialog use # --define "nodebug 1" in rpmbuild commandline %if "%{nodebug}" != "1" %define nodebug 0 %endif AND %if "%{nodebug}" == "0" %define optflags -g %ifnarch x86_64 # x86_64 does not have brp-compress %define __spec_install_post %{_libdir}/rpm/brp-compress %endif %endif %define debug_package %{nil} 8) also %build should contain only %configure --enable-smtp --enable-jasper-filter --sysconfdir=%{_sysconfdir} 9) Use following in %install to preserve timestamps if any need to be make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" 10) You have missing BR: openssl-devel, jasper-devel, esound-devel 11) upstream naming looks odd that uses release numbers also. 12) also we need patch to port spell checker from pspell to hunspell in configure.ac -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review