Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503189 --- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-06-01 06:08:06 EDT --- Koji scratch build link is for python-application package. Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1386637 + rpmlint is NOT silent for RPM. ==> See suggestion2. + source files match upstream url 599bba969380fadc719fb49a94e5efd95084637d python-gnutls-1.1.8.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package python-gnutls-1.1.8-2.fc12.i586 => Provides: _gnutls_init.so Requires: /usr/bin/env libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libgnutls-extra.so.26 libgnutls-extra.so.26(GNUTLS_1_4) libgnutls.so.26 libgnutls.so.26(GNUTLS_1_4) libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpython2.6.so.1.0 python(abi) = 2.6 rtld(GNU_HASH) + Not a GUI application Suggestions: 1) use %global instead %define 2) Add to %prep chmod 644 examples/*.py to silent rpmlint messages python-gnutls.i586: W: spurious-executable-perm /usr/share/doc/python-gnutls-1.1.8/examples/twisted-server.py python-gnutls.i586: W: spurious-executable-perm /usr/share/doc/python-gnutls-1.1.8/examples/client.py python-gnutls.i586: W: spurious-executable-perm /usr/share/doc/python-gnutls-1.1.8/examples/server.py python-gnutls.i586: W: spurious-executable-perm /usr/share/doc/python-gnutls-1.1.8/examples/twisted-client.py python-gnutls.i586: W: spurious-executable-perm /usr/share/doc/python-gnutls-1.1.8/examples/crypto.py python-gnutls.i586: W: doc-file-dependency /usr/share/doc/python-gnutls-1.1.8/examples/twisted-server.py /usr/bin/env python-gnutls.i586: W: doc-file-dependency /usr/share/doc/python-gnutls-1.1.8/examples/client.py /usr/bin/env python-gnutls.i586: W: doc-file-dependency /usr/share/doc/python-gnutls-1.1.8/examples/server.py /usr/bin/env python-gnutls.i586: W: doc-file-dependency /usr/share/doc/python-gnutls-1.1.8/examples/twisted-client.py /usr/bin/env python-gnutls.i586: W: doc-file-dependency /usr/share/doc/python-gnutls-1.1.8/examples/crypto.py /usr/bin/env APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review