Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226508 --- Comment #5 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-06-01 03:30:04 EDT --- Okay. - I wouldn't ship man as %doc. - Change BuildRequires: /usr/bin/desktop-file-install to BuildRequires: desktop-file-utils - You need to conserve time stamps in character set conversion, use for i in AUTHORS docs/man/{de,es}/*.?; do iconv -f iso-8859-1 -t utf-8 "$i" > "${i}_" && \ touch -r "$i" "${i}_" && \ mv "${i}_" "$i" done This is also safe, since it fails if a command is not completed OK. - I'm wondering if autoreconfing is really needed; you could just use the trick at http://fedoraproject.org/wiki/Packaging/Guidelines#Removing_Rpath - Why is clean commented out? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review