Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503202 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-06-01 01:56:25 EDT --- 1) use patch names prefixed with package name Patch0: blueproximity-fedorization.diff Patch1: blueproximity-fix-bash-script.diff also, change %prep as %patch0 -p0 -b .fedorization %patch1 -p0 -b .fix-bash-script 2) no need to use vendor in desktop-file-install. See http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage Remove fedora word from fedora-blueproximity.desktop file name. 3) files section should look like %files -f %{name}.lang %defattr(-,root,root,-) %doc ChangeLog COPYING README doc/ %{_datadir}/%{name} %{_bindir}/%{name} %{_datadir}/applications/fedora-%{name}.desktop %{_datadir}/pixmaps/%{name}_base.svg 4) fix following warning fedora-blueproximity.desktop: key "Categories" is a list and does not have a semicolon as trailing character 5) preserve timestamps by using install command as "install -p" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review