Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tellico - collection manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205041 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-09-03 01:35 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: a7ecc139d820279b0a89d8f594110094 tellico-1.2.tar.gz a7ecc139d820279b0a89d8f594110094 tellico-1.2.tar.gz.1 See below - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package is a GUI app and has a .desktop file OK - Package doesn't own any directories other packages own. OK - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. See below - Should build in mock. OK - Should have sane scriptlets. Issues: 1. In your desktop-file-install you have --vendor="", but according to guidelines that should be --vendor=fedora. Also, this causes builds under mock to fail because the fedora-tellio.desktop file doesn't exist. 2. INSTALL NEWS README can probibly all be dropped. INSTALL is the generic auto* install document, NEWS and README are both of size 0. 3. The Summary is a bit generic: Summary: collection manager Perhaps at least add that it's a KDE based collection manager? 4. rpmlint says: W: tellico summary-not-capitalized collection manager So, it should at least be "A KDE collection manager" -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review