Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503256 --- Comment #11 from Gareth John <gareth.l.john@xxxxxxxxxxxxxx> 2009-05-31 09:52:12 EDT --- Ok jussi i have done all that you have said plus some more, i also looked in #fedora to see if anyone could help before you had chance to reply and was told that i should include examples in the devel docs. So i tried to do this it took a while as i am rather busy with exams at the minute as well however here is the latest rev. and its changelog. ------------------------------- * Sun May 31 2009 Gareth John gareth.l.john@xxxxxxxxxxxxxx 0.4.0-3 - Changed summary to recomendation - Changed Build requirments to gtkmm24-devel only - Use name & version macro in the Source0 line - Dropped prefix from configure - Removed checking for remove build root under install - Added pkgconfig as requirement for devel package, for dir ownership. - Dropped the doc line from -devel, as the devel package requires the main package. - Tidy devel files as devel package should own the directories - Tidy package files. - Added chmod commands under install - Removed attr lines under files - Added patch to stop examples compiling - Added examples to devel docs - Added remove makefile from examples under prep -------------------------------- Rpmlint says: $ rpmlint ../RPMS/i386/gtkmm-utils-devel-0.4.0-3.fc10.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ../SRPMS/gtkmm-utils-0.4.0-3.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ../RPMS/i386/gtkmm-utils-0.4.0-3.fc10.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. --------------------------------- Files: http://garethsrpms.googlecode.com/files/gtkmm-utils.spec http://garethsrpms.googlecode.com/files/gtkmm-utils-0.4.0-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review