[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502978





--- Comment #2 from Silas Sewell <silas@xxxxxxxxx>  2009-05-30 15:21:41 EDT ---
I'm not sure the correct way to fix this, Koji doesn't create the pyc and pyo
files in bindir, but mock still does.

The documentation (
https://fedoraproject.org/wiki/Packaging/Python#Unnecessary_Byte_compilation )
recommends using the exclude, but as you've seen this breaks Koji builds.

I removed the exclude from the package above, but it will have the unnecessary
glob in the files' bindir (ex: %{_bindir}/kernprof.py*) and if you build with
mock the .pyc and .pyo files will be in the bindir along with the following
warnings.

rpmlint

[silas@silas rpmbuild]$ rpmlint /var/lib/mock/fedora-10-i386/result/*.rpm
python-line_profiler.i386: W: non-executable-in-bin /usr/bin/kernprof.pyc 0644
python-line_profiler.i386: W: non-executable-in-bin /usr/bin/kernprof.pyo 0644
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

SPEC Diff:
http://code.google.com/p/silassewell/source/diff?spec=svn280&r=280&format=side&path=/trunk/projects/packages/rpms/python-line_profiler/python-line_profiler.spec

SRPM URL:
http://silassewell.googlecode.com/files/python-line_profiler-1.0-0.2.b2.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]