Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495888 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-05-30 13:38:59 EDT --- Some notes: * BR - Using "BR: perl" is not preferred. Please specify perl module names needes as BRs more verbosely ( Usually this is "BuildRequires: perl(ExtUtils::MakeMaker) or so ) ref: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides * noarch vs optflags - This package is noarch so specifying %optflags is useless. * Macros - Use macros correctly. If you want to use %__perl, also use %__make, %__rm * Skipped tests - From build.log: ---------------------------------------------------------- 77 t/01_load.t ... ok 78 t/02_basic.t .. ok 79 t/99_pod.t .... skipped: Enable TEST_POD environment variable to test POD ---------------------------------------------------------- It seems TEST_POD environ should be set and BR: perl(Test::Pod) should be added. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review