Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502920 --- Comment #10 from Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> 2009-05-29 19:09:05 EDT --- (In reply to comment #9) > I really think this package should Require gnome-session, ^ Sorry, the word NOT was missing here. Some more comments: - License tag is wrong, should be LGPLv2+ instead of LGPLv2 - Why does %configure check for GConf? - "BuildRequires: gnome-doc-utils" seems wrong to me, AFAIKS only gtkdoc-check from gtk-doc is needed. - What is the use of " --enable-gtk-doc" if there are no docs? - package does not use parallel make, see https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make - Timestamps not preserved during make install, see https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps - This is the successor of PolicyKit-gnome, but the Provides and Obsoletes for it are missing. - HACKING and TODO are missing from %doc, possibly also NEWS, but this one is very outdated -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review