Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480279 --- Comment #35 from Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> 2009-05-29 16:39:48 EDT --- Sorry it took so long, but I'm still not happy with the spec. It was ok to drop the gtk-module package, but IMO the -common package should remain to avoid confusion. Otherwise people install gnome-globalmenu and wonder why the don't have a panel applet. If you renamed the base package to gnome-globalmenu-common you could make the gnome-applet-globalmenu provide gnome-applet-globalmenu for easy installation with yum. I have moved the gconf schema to the gnome-applet package and the xfce plugin still works nice. So why wait for a new release to move the file? Use %global instead of %define, see https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define Requires(pre|post|preun): GConf2 and the GConf scriptlets are in the base package, but they belong to the gnome-applet package. Only ldconfig will remain in the base package. You could replace it with "%post -p /sbin/ldconfig" and drop the Requires(post|postun) for ldconfig, rpm will take care of this. Of course it needs to be "%post -p common /sbin/ldconfig" if you renamed the base package. The conditionals are bad. You only want to build the xfce plugin in Fedora. So you better use "%if 0%{?fedora}" configure can be more simplified to %configure --disable-schemas-install \ --disable-static \ --disable-tests \ --with-gnome-panel \ --docdir=%{pkgdocdir} \ %if 0%{?fedora} --with-xfce4-panel %else --without-xfce4-panel %endif -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review