Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502979 --- Comment #3 from Adam Miller <maxamillion@xxxxxxxxx> 2009-05-28 09:41:56 EDT --- I fixed the URL/Source0 mishap, that one was a horrible oversight by myself. Don't need expat-devel, I built the SRPM in mock to verify and I'd rather leave the Requires for personal sanity as opposed to relying on the auto-fu but if there is a guideline saying otherwise I will happily oblige. Got rid of the extra >>'s Changed the Icon listing This was an oversight/laziness as a side effect of fedora vim auto generating a template for me with $RPM_BUILD_ROOT, it has been fixed. Dropped the %{_datadir}/applications listing in %files. Spec URL: http://maxamillion.fedorapeople.org/ophcrack.spec SRPM URL: http://maxamillion.fedorapeople.org/ophcrack-3.2.1-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review