Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502986 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@xxxxxxxxx --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-05-28 03:33:51 EDT --- 1) Add dist tag as per given at http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Using_the_.25.7B.3Fdist.7D_Tag 2) As README clearly said license is as per given in COPYING so change it to GPLv2+ 3) %build should be make CFLAGS="$RPM_OPT_FLAGS" DESTDIR="%{_prefix}" 4)Use macros in %install section. Look https://fedoraproject.org/wiki/Packaging/RPMMacros 5) Don't add user and group while using install commands for ytree and ytree.1 in %install 6) Remove %post 7) Change Source to Source0: http://www.han.de/~werner/%{name}-%{version}.tar.gz 8) Change readline BR as BuildRequires: readline-devel >= 4.3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review