Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225809 --- Comment #25 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-05-27 18:16:10 EDT --- I note that 4.3.1 has recently been released, but that doesn't really have any bearing on this review. There is no reason for: Requires(post): /sbin/install-info Requires(preun): /sbin/install-info because you're using the "-p" forms of the scriptlets: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig The license of the demos is GPL, not LGPL, but those aren't packaged so the license tag is correct. The README file is duplicated between the three packages; it should not be. Normally I would complain about such a generic name as /usr/include/mp.h, but this package has been around approximately forever. So I see only two minor issues. If you like, I can just go ahead and fix them up and call this done. * source files match upstream. sha256sum: 5420b0e558a69a53b36f2b2c70a69f547e075d98366a585fc80cbbcce1efe368 gmp-4.2.4.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint has acceptable complaints. * final provides and requires are sane: gmp-4.2.4-6.fc11.x86_64.rpm libgmp.so.3()(64bit) libgmpxx.so.4()(64bit) libmp.so.3()(64bit) gmp = 4.2.4-6.fc11 gmp(x86-64) = 4.2.4-6.fc11 = /sbin/ldconfig libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgmp.so.3()(64bit) libgmpxx.so.4()(64bit) libmp.so.3()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.11)(64bit) gmp-devel-4.2.4-6.fc11.x86_64.rpm gmp-devel = 4.2.4-6.fc11 gmp-devel(x86-64) = 4.2.4-6.fc11 = /bin/sh /sbin/install-info gmp = 4.2.4-6.fc11 libgmp.so.3()(64bit) libgmpxx.so.4()(64bit) libmp.so.3()(64bit) gmp-static-4.2.4-6.fc11.x86_64.rpm gmp-static = 4.2.4-6.fc11 gmp-static(x86-64) = 4.2.4-6.fc11 = gmp-devel = 4.2.4-6.fc11 * %check is present and all tests pass: All 9 tests passed All 10 tests passed All 56 tests passed All 11 tests passed All 26 tests passed All 7 tests passed All 3 tests passed All 14 tests passed All 3 tests passed * shared libraries are installed: ldconfig is called properly. unversioned .so links are in the -devel package. * owns the directories it creates. * doesn't own any directories it shouldn't. X README file is duplicated in %files. * file permissions are appropriate. * scriptlets are OK (ldconfig, info installation) * code, not content. * headers are in the -devel package. * no pkgconfig files. * static libraries are in a separate -static package. * no libtool .la files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review