Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473583 --- Comment #22 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2009-05-27 15:50:05 EDT --- Last thing, sorry for not noticing it earlier: You've currently got: %files %defattr(-,root,root,-) %doc AUTHORS COPYING INSTALL ChangeLog README doc/{html,ps,pdf} ... %{_datadir}/%{name}-%{version}/dict/* %{_datadir}/%{name}-%{version}/doc/html/* %{_datadir}/%{name}-%{version}/doc/pdf/* %{_datadir}/%{name}-%{version}/doc/ps/* %{_datadir}/%{name}-%{version}/lib/wnres/* There are two problems here. 1. You're not owning the %{_datadir}/%{name}-%{version}/ dir, just the directories beneath it. You can solve this problem by replacing the subdirs with wildcards with simply: %{_datadir}/%{name}-%{version}/ That translates into "own this directory and all files and directories underneath it". 2. You're packaging up duplicate copies of the same html,ps,pdf docs, in two different location. The ones in %{_datadir}/%{name}-%{version}/doc/ don't have %doc attribution, so they should just be manually removed after make install is done. # Remove duplicate copies of docs installed by make install rm -rf $RPM_BUILD_ROOT%{_datadir}/%{name}-%{version}/doc Show me a new spec with both issues fixed and I'll finish this review off and sponsor you. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review