Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491518 --- Comment #16 from Hans de Goede <hdegoede@xxxxxxxxxx> 2009-05-27 13:30:37 EDT --- Reviewing as the flags policy has been suspended for now. Full review done: MUST FIX -------- * The docs are currently duplicated between the main package and the -docs package. put the README, COPYING etc only in the main package and the rest in the -docs package * Make the -docs package Require the main package (with full evr) * Upstream source files are AWOL (newer RC?) so I cannot verify the origin of the files included in the srpm SHOULD FIX ---------- * Why aren't you using %configure, if there is a specific reason not to please add a comment explaining this to the .spec file * Don't untar %{SOURCE1} in %build instead add " -a 1" as extra arguments to %setup, or even better take a look at generating the docs buildtime as suggested in comment #14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review