Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502795 --- Comment #2 from Chitlesh GOORAH <chitlesh@xxxxxxxxx> 2009-05-27 06:25:23 EDT --- #01: This is a no-arch application. Add BuildArch: noarch to the spec file #02: rpmlint on SRPM rpmlint package helps to qualify a SRPM or a RPM. It should be applied to every RPM produced by the spec file. Errors and warnings should be corrected. A common fix list of errors and warnings is listed on : https://fedoraproject.org/wiki/Common_Rpmlint_issues rpmlint /home/chitlesh/rpmbuild/SRPMS/mcu8051ide-1.1-2.fc10.src.rpm mcu8051ide.src: E: description-line-too-long Integrated Development Enviroment for some MCS-51 based microcontrollers (e.g. AT89S8253). Supported languages are assembly and C. 1 packages and 0 specfiles checked; 1 errors, 0 warnings Break it into several lines. #03: Keeping timestamps Can you patch the install.sh file so that during cp timestamps are preserved. cp --> cp -p There are some typos in the install.sh files as well : example: successuful, Unistallation Then send the patch to upstream. #04: rpmlint on the RPM Here there are several errors and warnings. In most cases the fix should be in the %prep stage. # rpmlint : hidden-file-or-dir, backup-file-in-package and zero-length rm lib/.tex* rm lib/.html in %install # rpmlint : non-executable-script chmod 0755 %{buildroot}%{_datadir}/%{name}/lib/*.tcl Tip: To check the permissions of the files of a RPM without installing the rpm $ rpm -qvlp /home/chitlesh/rpmbuild/RPMS/noarch/mcu8051ide-1.1-2.fc10.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review