Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472696 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-05-25 04:21:17 EDT --- Some notes for 0.2-1.61: * Versioning / creating tarball - If you want to rebase source tarball on svn repository, please follow: * To create tarball: https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control * For versioning: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages * BR (BuildRequires) - This package does not build without "BR: cvs" http://koji.fedoraproject.org/koji/taskinfo?taskID=1374931 - I guess "BR: gettext-devel" can be changed to "BR: gettext" and "BR: subversion" is not needed (once the tarball is created) (koji scratch build succeeds) - When perl module related packages are needed for BR, please avoid to use direct name of the package but use virtual name which the needed rpm provides: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides (i.e. change to "BuildRequires: perl(XML::Parser)" - "BR: glib2-devel" is redundant because gtk2-devel requires glib2-devel. * %configure usage - "--prefix=%{_prefix}" or so is not needed for %configure ! You can check what %configure actually does by $ rpm --eval %configure * desktop-file-utils usage - "desktop-file-validate" must be called for the files installed under %buildroot (i.e after "make install") * Keeping timestamps - Please consider to use ------------------------------------------------------------------ make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------------------ to keep timestamps on installed files. This method usually works for Makefiles generated by recent autotools. * Documents ! This software is actually under GPLv2 (from the source codes), however "COPYING" file is GPLv3 text. - "ABOUT-NLS" is not useful for this package because this (usually) shows general information for transformation. * Desktop files - Usually desktop files should be installed under %_datadir/applications. Would you check if %_datadir/vcards-evo-daemon is the desired directory for desktop files to be installed for this package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review