Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483434 --- Comment #14 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-05-24 14:47:26 EDT --- (In reply to comment #13) > Hello, > > All changes were applied as suggested. > The new src.rpm can be downloaded from: > http://downloads.sourceforge.net/argtable/argtable2-11-2.fc11.src.rpm What about the spec file? I'd suggest using something else than the project home page, as the review process may take many steps before everything is in order. > I'm actually pretty fond of using macros but if you see a good reason not to, > I'm willing to modify the spec file accordingly. Well, it's not an official guideline; I just think it isn't good style as nothing is gained from using the macros: KISS! Do you still need a sponsor? I can sponsor you, if you show me you know the Fedora Packaging guidelines. Thus you need to do a couple of informal reviews (as Christian did on this package), and make at least one another package submission. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review