Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474787 --- Comment #8 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-05-23 07:54:52 EDT --- Notes: * The %build section still doesn't honour %optflags. You should fix your spec in the following way: - echo OPT=-O2 -fPIC >> make.settings.local + echo "OPT=%{optflags}" >> make.settings.local * Regarding %install section - you may shorten it a bit by replacing mkdir %{buildroot} mkdir -p %{buildroot}/%{_libdir}/ cp ./lib/libstxxl.so %{buildroot}/%{_libdir}/libstxxl.so.%{version} with install -p -D -m 0755 ./lib/libstxxl.so %{buildroot}/%{_libdir}/libstxxl.so.%{version} * You also don't need to explicitly install doc-files. Just enumerate them in %files section properly. Let's assume, that you wish to install TROUBLESHOOTING file as %doc - all you need is to add %files %doc TROUBLESHOOTING and rpmbuild will cd into rpmbuild/BUILD/stxxl-1.2.1 directory and will search TROUBLESHOOTING here. So you should remove the following lines: mkdir -p %{buildroot}/%{_docdir}/ #Install Documentation mkdir -p %{buildroot}/%{_docdir}/stxxl-1.2.1/ mkdir -p %{buildroot}/%{_docdir}/stxxl-1.2.1/doxy cp -pr doc/doxy/* %{buildroot}/%{_docdir}/stxxl-1.2.1/doxy #cp -pr doc/tutorial/tutorial.pdf %{buildroot}/%{_docdir}/stxxl-1.2.1/ #cp -p doc/tutorial/tutorial.dvi %{buildroot}/%{_docdir}/stxxl-1.2.1/ mkdir -p %{buildroot}/%{_docdir}/stxxl-1.2.1/examples/ cp -p doc/tutorial/examples/* %{buildroot}/%{_docdir}/stxxl-1.2.1/examples/ cp -p config_example %{buildroot}/%{_docdir}/stxxl-1.2.1/ and just add %doc doc/doxy/* doc/tutorial/examples/* config_example to "%files devel" section. Of course, docs will be installed into %{_docdir}/stxxl-devel-1.2.1/ directory. * Consider adding README and TROUBLESHOOTING to %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review