Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466737 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #25 from Hans de Goede <hdegoede@xxxxxxxxxx> 2009-05-23 03:57:07 EDT --- (In reply to comment #24) > (In reply to comment #23) > ... > > Should Fix: > > ----------- > ... > > * Consider renaming the manpages to mathio-<foo> and installing them > Actually, thoses manpages are removed from matio svn trunk. My view is that > they provide the same information as doxygen (since both pdf and manpages are > generated from doxygen). Keeping html doxygen is lightweight and Ok. > > * Is it really useful to put the test files in a subpacke, wouldn't it be > > better > > to run them as %check and not put them in an rpm at all ? > Nice suggest. I've done that since the test_* file are likely not useful beyond > build time. > Much better :) > All others point are fixed. > Ack, looks good now, APPROVED! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review