Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: geda-gschem - Electronics schematics editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204598 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-09-02 08:07 EST ------- Second review for geda-gschem. 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Encoding - iconv -f EUCJP -t UTF8 AUTHORS.tmp > AUTHORS && \ Well... not EUCJP but ISO-8859-1 at this case. * Desktop files - Well: fedora-gschem.desktop has the entry: Icon=geda However, no icons are included in this package. Also, geda.png is included in geda rpm. If you want to use this png file, this bug must be blocked by bug 204259 and Requires: geda is needed. Perhaps you don't want this. So + Copy some png (or xpm) file and include it in this package. ( or you can use xpm file included in this package ). + Install the image file into /usr/share/icons/hicolor/...... as gschem.{png,xpm} (or use link) + Call gtk-update-icon-cache on %post and %postun. = File and Directory Ownership is now solved. 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing. 3. Other things I have noticed: = Nothing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review