Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499986 Thomas Sailer <t.sailer@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |t.sailer@xxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |t.sailer@xxxxxxxxxxxxxx --- Comment #2 from Thomas Sailer <t.sailer@xxxxxxxxxxxxxx> 2009-05-21 19:58:03 EDT --- Source0 path should be http://ftp.gnu.org/gnu/libidn/libidn-%{version}.tar.gz Fedora review mingw32-libidn-1.14-1.fc11.src.rpm 2009-05-22 Another scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1369425 rpmlint output: $ rpmlint mingw32-libidn.spec mingw32-libidn-1.14-1.fc12.src.rpm mingw32-libidn-1.14-1.fc12.noarch.rpm mingw32-libidn-static-1.14-1.fc12.noarch.rpm mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/cs/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/da/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/de/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/en@boldquot/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/en@quot/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/eo/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/fi/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/fr/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/id/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/it/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/ja/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/nl/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/pl/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/ro/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/sr/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/vi/LC_MESSAGES/libidn.mo mingw32-libidn.noarch: W: file-not-in-%lang /usr/i686-pc-mingw32/sys-root/mingw/share/locale/zh_CN/LC_MESSAGES/libidn.mo mingw32-libidn-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libidn.a mingw32-libidn-static.noarch: W: no-documentation 3 packages and 1 specfiles checked; 1 errors, 18 warnings. As per Packaging/MinGW, these errors can be ignored. + OK ! needs attention + rpmlint output + Package is named according to Fedora MinGW packaging guidelines + Specfile name matches the package base name + Package follows the Fedora MinGW packaging guidelines + License meets guidelines and is acceptable to Fedora LGPLv2+ + License matches the actual package license It is also the same as in the corresponding Fedora libidn package + The package contains the license file (COPYING, COPYING.LIB) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm 2ac3913b2d6c42bf445e7c55db3e2a99 libidn-1.14.tar.gz 2ac3913b2d6c42bf445e7c55db3e2a99 x/libidn-1.14.tar.gz n/a Package builds in mock n/a ExcludeArch bugs filed + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun + Does not use Prefix: /usr + Package owns all directories it creates + No duplicate files in %files + %files has %defattr + %clean contains rm -rf $RPM_BUILD_ROOT + Consistent use of macros + Package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Fedora MinGW guidelines allow headers in main package + Static libraries should be in -static + Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a -devel must require the fully versioned base n/a Packages should not contain libtool .la files Fedora MinGW guidelines allow .la files n/a Packages containing GUI apps must include %{name}.desktop file + Packages must not own files or directories owned by other packages + %install begins with rm -rf $RPM_BUILD_ROOT + Filenames must be valid UTF-8 ! use %global instead of %define ! Source0 path invalid ! the commented references to Patch0 should go IMO -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review