Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493250 --- Comment #20 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-05-21 14:01:25 EDT --- Well * Please address the issues of - directory ownership (mentioned in my comment 4) - and changing "tetris" word on script name and in documents (mentioned in spot's comment 5) * About patching ------------------------------------------------------- patch -p0 -b --suffix .warning < %{SOURCE1} ------------------------------------------------------- - This can be replaced by ------------------------------------------------------- %patch1 -p0 -b .warning ------------------------------------------------------- * Make build log more verbose - This package also shows build log like: ------------------------------------------------------- 77 /usr/bin/perl -MExtUtils::Command -e mkpath blib/lib/Goo/Canvas 78 [ CC xs/goocanvas.c ] 79 [ CC xs/goocanvasbounds.c ] 80 [ CC xs/goocanvasellipse.c ] 81 [ CC xs/goocanvasgroup.c ] ------------------------------------------------------- which is not so useful. Please make build.log more verbose, to show if Fedora specific compilation flags are correctly honored, for example. For this package the following works. ------------------------------------------------------- make %{?_smp_mflags} NOECHO= ------------------------------------------------------- And please change the release number. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review