Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495399 Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |nicolas.mailhot@xxxxxxxxxxx Flag| |fedora-review?, | |needinfo?(sanjay.ankur@gmai | |l.com) --- Comment #3 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> 2009-05-21 13:18:59 EDT --- First review: 1. W: file-not-utf8 /usr/share/doc/NotCourier-Sans-sfd-fonts-20080906/FONTLOG.txt ⇒ please use iconv to fix this file's encoding (you have an example in sil andika, make sure you've the right source encoding though) 2. please use lowercase package naming only as requested by the fonts packaging guidelines 3. please add the oflb- foundry prefix to the package name 4. unless the fonts authors asked you to, I don't thing the -sfd postfix is really needed 5. your URL does not work 6. it seems upstreams versions this font properly, so you can use a real version instead of a timestamp (current is 1.1) 7. I'd drop the first § of your description 8. the font is derived from a GPL font so it must stay GPL. Upstream has already fixed this in its last release (do not forget to update your %doc) 9. Be very careful to use the exact name the font declares in your fontconfig file. For version 1.1, it will be "NotCourierSans" 10. since the fonts are missing an italic face, I wouldn't stack them at 60 in fontconfig, 61 or 62 would be better Anyway that's all for now, thank you for continuing to package Fedora fonts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review