Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: obmenu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195871 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-09-01 23:15 EST ------- Thanks for the prelim comments Parag. Here's a formal review: OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 710036a5edc9886d6d563ce46c747432 obmenu-1.0.tar.gz 710036a5edc9886d6d563ce46c747432 obmenu-1.0.tar.gz.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. See below - Package is a GUI app and has a .desktop file OK - Package doesn't own any directories other packages own. OK - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. The new improved python guidelines require not ghosting, but including the .pyo files. Can you make that change? 2. You don't use python_sitearch, so might skip defining it at the top. 3. Should this package have a desktop file? See: http://www.fedoraproject.org/wiki/Packaging/Guidelines#desktop 4. If I install this package and try and run it, I get: Error: "/home/kevin/.config/openbox/menu.xml" not found Should this package then 'Require: openbox' ? Or otherwise require a menu.xml file? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review