Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501924 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |erik-fedora@xxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |erik-fedora@xxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> 2009-05-21 09:22:54 EDT --- This one is quite hard to read, due to the frequent use of macros. However, I don't think it can be done any other way, so I'll do my best to read through them. ---- The %files list contains some redundant entries: %dir %{_mingw32_libdir}/%{name1}%{majorver} %dir %{_mingw32_libdir}/dde* %dir %{_mingw32_libdir}/reg* %{_mingw32_libdir}/%{name1}%{majorver}/* %{_mingw32_libdir}/dde*/* %{_mingw32_libdir}/reg*/* These can be simplified to: %{_mingw32_libdir}/%{name1}%{majorver}/ %{_mingw32_libdir}/dde*/ %{_mingw32_libdir}/reg*/ ---- For readability, you might want to move this piece of code to the top of the .spec file: # don't run "make test" by default %{?_without_check: %define _without_check 0} %{!?_without_check: %define _without_check 1} ---- Is the rename of the import libraries from .a to .dll.a really necessary? AFAIK, this is only needed for libtool based libraries (which tcl isn't) ---- The native tcl package is now at version 8.5.7. You might want to update to that version too. See http://cvs.fedoraproject.org/viewvc/rpms/tcl/devel/tcl.spec?view=log for the complete list of changes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review