Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497639 Igor Jurišković <juriskovic.igor@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo? --- Comment #7 from Igor Jurišković <juriskovic.igor@xxxxxxxxx> 2009-05-21 06:59:25 EDT --- This is completely different package. Above full review doesnt count on this one. Will make new one after these few errors are fixed. Ok, lets see; -------------------------------------------------------------------- - https://fedoraproject.org/wiki/Packaging/Python#System_Architecture - says if you are installing something to global site_packages directory use following: %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} Please change python_sitearch with python_sitelib as stated at link above. Dont forget to change all %{python_sitearch} with new one. -------------------------------------------------------------------- -------------------------------------------------------------------- - remove --vendor. -------------------------------------------------------------------- -------------------------------------------------------------------- - desktop file has Encoding. It is assumed that encoding is UTF-8 by default so that line is useless. Please remove it. -------------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review