Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492583 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-05-20 17:26:06 EDT --- (In reply to comment #5) > I hope everything is fixed now, I didn't notice upstream's license change. > When adding Requires: libpurple, rpmlint says E: explicit-lib-dependency > libpurple > so I dropped that tag again... RPM is recognizing it by itself. Besides, > Requires: pidgin automatically pulls in libpurple. Oh, sometimes you don't have to care about rpmlint's warnings since it does produce some false positives; this is one very common type of them. Due to the dir ownership issue it IS wanted that libpurple is explicitly required; the rpmlint warning can be ignored. I don't have an xfire account, so I can't test this. From a packaging point of view the package looks good, though. APPROVED PS. A final nitpick: I'd use %{_datadir}/pixmaps/pidgin/protocols/*/%{srcname}.png instead of %{_datadir}/pixmaps/pidgin/protocols/*/%{srcname}* since thus one sees straight away what kind of stuff in is in those directories. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review