Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdetv - KDE application for watching TV https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204421 ------- Additional Comments From packages@xxxxxxxxxxxxxxxxxx 2006-09-01 16:40 EST ------- (In reply to comment #2) > 0. Curious, why is this GPL/LPGL? Included in the original archive are the two license files COPYING (GPL) and COPYING.LIB (LGPL) so I thought, perhaps incorrectly that kdetv's libs were LGPL but kdetv is itself GPL. :-) > 1. SHOULD: instead of manually deleting applnk, instead use > desktop-file-install --delete-original Thanks, I've fixed this. > 2. SHOULD: Since this isn't a .desktop provided by fedora, imo, you needn't use: > desktop-file-install --vendor="fedora" > but instead use --vendor="" I've fixed this also, the latest version should be listed below, thanks :) http://dribble.org.uk/reviews/kdetv.spec http://dribble.org.uk/reviews/kdetv-0.8.9-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review