Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501353 --- Comment #10 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-05-19 13:26:14 EDT --- Good: + Basename of the SPEC files matches with packagename + Packagename fullfill naming guildelines + URL tag shows on proper project homepage + Package contains most recent stable release of the application + Could download upstream tar ball via spectool -g + Package sources matches with upstream (md5sum: 8fb7540bf2a7a8e1fa0086708ed9b881) + Consistently rpm macro usage in this package + Package has no subpackages + Package has proper license tag + License tag exclaim GPLv2 as a valid OSS license + Package contains verbatin copy of the license text + Package support SMP build + Local install and uninstall works fine + Call of the application works fine + Koji scratch build works fine + Package has small %doc stanza, so we need no extra doc subpackage + Files has proper file permission + All packaged files are owned by the package + %files stanza has no duplicated entries + No packaged file belong to another package Bad: - Copyright headers have only a refernce to the LICENSE/COPYING file. Please talk to upstream, that he should include a more clean copyright note on the source file - Please remove the Packager tag - You don't need to test the existance of the Buildroot before cleaning it. - build don't honour RPM_OPT_FLAGS - Rpmlint has warning on source rpm: pmlint ascii-3.8-2.fc10.src.rpm ascii.src: W: summary-not-capitalized interactive ASCII name and synonym chart ascii.src: W: name-repeated-in-summary ASCII ascii.src: W: non-standard-group Utilities/Text ascii.src: W: mixed-use-of-spaces-and-tabs (spaces: line 72, tab: line 82) 1 packages and 0 specfiles checked; 0 errors, 4 warnings. - Rpmlint complaints binary package: rpmlint ascii-3.8-2.fc10.x86_64.rpm ascii.x86_64: W: summary-not-capitalized interactive ASCII name and synonym chart ascii.x86_64: W: name-repeated-in-summary ASCII ascii.x86_64: W: non-standard-group Utilities/Text 1 packages and 0 specfiles checked; 0 errors, 3 warnings. - Debuginfo package doesn't contains sources - Please remove the old Changelog and beginning with a new one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review