Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501498 Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jochen@xxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jochen@xxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-05-19 12:13:15 EDT --- For a beginner you have provide a nice well-suited package. There are only thwo minor issues which you may fix easily. So I tell you, that I want to sponsor you, after the package will be approved. Good: + Basename SPEC filename matches which package name + Package name fullfill naming guidelines + URL tag shows on proper project homepage + Package contains most recent stable release of the software + Could download upstream tar ball via spectool -g + Packaged tar ball matches with upstream (md5sum: 4f6fe66dbd9fb3249dd201fd843b8319) + Package contains proper license tag + License tag states GPLv2 as a valid OSS license + Consistently rpm macro usage in package + Package doesn't contains any subpackage + Proper Buildroot defintion + Buildroot will be cleaned at the beginning of %clean and %install + Package contains verbatin copy of the license text + Local build works fine + Package support SMP build + Build honours RPM_OPT_FLAGS + Rpmlint is silient on source rpm + Rpmlint is silent on binary rpm + Debuginfo package contains sources + Local install and uninstall works fine + Application doesn't crash on start + Koji build works fine + Files in the files stanza has proper files permission + All packaged files are owned by the pacakge + No packaged file is owned by another package + %doc stanza is small, so we need no extra doc subpackage + Patckage has prpoer %Changelog Bad: - Copyright notes in the source files haeaders state GPLv2+ as license for the package - You can remove the requires ncurses line, because rpm create automaticly a Require to the library -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review