Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500476 --- Comment #4 from Louis Lagendijk <louis@xxxxxxxxxxxxxxxxxxx> 2009-05-18 17:11:06 EDT --- (In reply to comment #3) > Hello Louis. > > This is not official review. I'm looking for a sponsor like you. > ---------------------------------------------------------------- > - remove Vendor tag. Its not needed. > ---------------------------------------------------------------- > good catch, a left over from the Sourceforge release > ---------------------------------------------------------------- > - Consider using parallel make if possible. If not write in comment above make > why not. https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make > ---------------------------------------------------------------- > done > ---------------------------------------------------------------- > - install doesn't preserve timestamps. Add INSTALL="install -p" like: > make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" install > http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25install_section > ---------------------------------------------------------------- > done > ---------------------------------------------------------------- > - update package to new version. > ---------------------------------------------------------------- > Not sure what you mean here. Anyhow, the versions available now are based on the version I released on sourceforge Sat May 16 > ---------------------------------------------------------------- > - I'm unable to download source but are you sure that License is only GPL? If > possible be more specific like GPLv3+... > ---------------------------------------------------------------- > See license included. It is actually the Cups license, which is GPLv2. Corrected. > ---------------------------------------------------------------- > - %doc part can go into one line. Its easier to read but its your choice. > ---------------------------------------------------------------- > Done > ---------------------------------------------------------------- > - you need to make space between changelogs: > > * Thu Mar 12 2009 Louis Lagendijk <llagendijk@xxxxxxxxxxxxxxxxxxxxx> > - something > > * Thu Feb 19 2009 Louis Lagendijk <llagendijk@xxxxxxxxxxxxxxxxxxxxx> > - something > > * ... > Done > ---------------------------------------------------------------- > - you're missing "-" at the beginning of some changes. > ---------------------------------------------------------------- > Done > ---------------------------------------------------------------- > - changelog part is missing version and release number: > > * Thu Mar 12 2009 Louis Lagendijk <llagendijk@xxxxxxxxxxxxxxxxxxxxx> > <version>-<release> > ---------------------------------------------------------------- Done I found a few more issues when I ran rpmlint on the srp. These are corrected as well. New versions available: Spec URL: http://www.fazant.net/cups-bjnp/cups-bjnp.spec SRPM URL: http://www.fazant.net/cups-bjnp/cups-bjnp-0.5.3-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review