Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204694 ------- Additional Comments From packages@xxxxxxxxxxxxxxxxxx 2006-09-01 12:37 EST ------- > W: zvbi no-reload-entry /etc/rc.d/init.d/zvbid > In your init script (/etc/rc.d/init.d/your_file), you don't > have a 'reload' entry, which is necessary for good functionality. > > W: zvbi incoherent-init-script-name zvbid > The init script name should be the same as the package name in lower case. > > all above warnings have their descriptions given about how to solve them so > follow that. I'm in agreement with Rex on this one, I think calling the init script zvbi in this case doesn't make much sense, particularly when the daemon is really a small subset of the whole zvbi package, as opposed to being the primary function. It would require more than a simple namechange as the init script would need to be patched so that the 'subsystems' had matching names. Overkill I think for simply dropping the trailing 'd'. With wrt the reload option as it's considered optional I would rather not add it. IIRC primary reason for a reload option is to tell the daemon to reload its config files without quitting and starting again which is very useful for daemons that don't instantly stop or start such as squid, but in this case zvbid doesn't load configs. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review