Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497441 --- Comment #65 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-05-18 13:15:56 EDT --- For -11: * Again user directory for mumble-server: - As said above, using %{buildroot} cannot be accepted here because %buildroot should be used only when building this package, and when installing murmur binary rpm this directory (%buildroot) is not expected to exist. Please change this to "-d %{_localstatedir}/lib/mumble-server" ! Scriptlets - By the way is "condrestart" scriptlets at "%postun" unneeded for murmur service? If it is preferable to add this, please check %postun example on https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets * %{name}-server symlink ------------------------------------------------------- ln -s ../sbin/murmurd %{buildroot}%{_sbindir}/%{name}-server ------------------------------------------------------- - As murmurd and %{name}-server are now in the same directory, this can be simplified to: ------------------------------------------------------- ln -s murmurd %{buildroot}%{_sbindir}/%{name}-server ------------------------------------------------------- Now: ------------------------------------------------------------- NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora package collection review requests which are waiting for someone to review can be checked on my wiki page: http://fedoraproject.org/wiki/User:Mtasaka#B._Review_request_tickets (Check "No one is reviewing") Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review