Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: zvbi - Raw VBI, Teletext and Closed Caption decoding library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204694 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2006-09-01 08:28 EST ------- I can review this. At first glance, package looks clean, just a few items off the top of my head so far: 1. in -devel: Change Requires: zvbi = %{version}-%{release} to the less error-prone: Requires: %{name} = %{version}-%{release} 2. in %post/%postun fonts, change /usr/bin/fc-cache %{_datadir}/fonts to /usr/bin/fc-cache %{_datadir}/fonts/%{name} no need to tell fc-cache to reparse *all* of %_datadir/fonts, when we're only interested in %_datadir/fonts/%name 3. -fonts: I'm pretty sure there's no real need for Requires: fontconfig Requires(post): /usr/bin/fc-cache Requires(postun): /usr/bin/fc-cache The pkg doesn't *really* need/use fontconfig, and the calls to fc-cache in scriptlets are wrapped with: if [ -x /usr/bin/fc-cache ]; then ... fi -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review