Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=496880 --- Comment #7 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-05-15 08:41:36 EDT --- (In reply to comment #3) > Comment: the name of the executable is 'wannier90.x'. Not a > blocker, but a little unusual. I don't want to break compatibility with upstream, so I'm keeping the name of the binary as is. (In reply to comment #4) > wannier90-devel.i586: W: no-documentation > > It would be worth adding at least the license file to this > package, I think. IMHO it's not needed, since the devel package requires the base package that contains the documentation along with the license. > wannier90-libs.i586: W: unstripped-binary-or-object /usr/lib/libwannier.so > > You probably want to strip this one, although I guess this > might break debuginfo. Merged this with the main package, as I made the executable link to the shared library. The warning was caused by find-debuginfo.sh not finding the non-executable library, it works now. > wannier90-libs.i586: W: no-soname /usr/lib/libwannier.so > > This is a consequence of upstream's peculiar build process. > Persuade them to use libtool :-) Upstream builds a static library, I changed the makefile to build a shared library instead. (In reply to comment #5) > Comment: Would be worth including the examples/ subdirectory > from the source, particularly since it is mentioned in the README > file. Done. http://theory.physics.helsinki.fi/~jzlehtol/rpms/wannier90.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/wannier90-1.1-3.fc10.src.rpm rpmlint output: wannier90.x86_64: W: no-soname /usr/lib64/libwannier.so wannier90-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings. These can be ignored, as mentioned above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review