Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497283 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #8 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-05-15 03:37:05 EDT --- Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1355746 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 0afce4a365d5a13a40f13031a1f6dc9bfa6a9788 Syntax-Highlight-Engine-Kate-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=528, 47 wallclock secs ( 0.13 usr 0.00 sys + 47.13 cusr 0.05 csys = 47.31 CPU) + Package perl-Syntax-Highlight-Engine-Kate-0.04-4.fc12.noarch => Provides: perl(Syntax::Highlight::Engine::Kate) = 0.04 perl(Syntax::Highlight::Engine::Kate::ABC) = 0.03 perl(Syntax::Highlight::Engine::Kate::AHDL) = 0.03 perl(Syntax::Highlight::Engine::Kate::ANSI_C89) = 0.03 perl(Syntax::Highlight::Engine::Kate::ASP) = 0.03 perl(Syntax::Highlight::Engine::Kate::AVR_Assembler) = 0.03 perl(Syntax::Highlight::Engine::Kate::AWK) = 0.03 perl(Syntax::Highlight::Engine::Kate::Ada) = 0.03 perl(Syntax::Highlight::Engine::Kate::Alerts) = 0.03 perl(Syntax::Highlight::Engine::Kate::All) = 0.02 perl(Syntax::Highlight::Engine::Kate::Ansys) = 0.03 perl(Syntax::Highlight::Engine::Kate::Apache_Configuration) = 0.03 perl(Syntax::Highlight::Engine::Kate::Asm6502) = 0.03 perl(Syntax::Highlight::Engine::Kate::Bash) = 0.03 perl(Syntax::Highlight::Engine::Kate::BibTeX) = 0.03 perl(Syntax::Highlight::Engine::Kate::C) = 0.03 perl(Syntax::Highlight::Engine::Kate::CGiS) = 0.03 perl(Syntax::Highlight::Engine::Kate::CMake) = 0.03 perl(Syntax::Highlight::Engine::Kate::CSS) = 0.03 perl(Syntax::Highlight::Engine::Kate::CSS_PHP) = 0.03 perl(Syntax::Highlight::Engine::Kate::CUE_Sheet) = 0.03 perl(Syntax::Highlight::Engine::Kate::Cdash) = 0.03 perl(Syntax::Highlight::Engine::Kate::Cg) = 0.03 perl(Syntax::Highlight::Engine::Kate::ChangeLog) = 0.03 perl(Syntax::Highlight::Engine::Kate::Cisco) = 0.03 perl(Syntax::Highlight::Engine::Kate::Clipper) = 0.03 perl(Syntax::Highlight::Engine::Kate::ColdFusion) = 0.03 perl(Syntax::Highlight::Engine::Kate::Common_Lisp) = 0.03 perl(Syntax::Highlight::Engine::Kate::ComponentminusPascal) = 0.03 perl(Syntax::Highlight::Engine::Kate::Cplusplus) = 0.03 perl(Syntax::Highlight::Engine::Kate::D) = 0.03 perl(Syntax::Highlight::Engine::Kate::De_DE) = 0.03 perl(Syntax::Highlight::Engine::Kate::Debian_Changelog) = 0.03 perl(Syntax::Highlight::Engine::Kate::Debian_Control) = 0.03 perl(Syntax::Highlight::Engine::Kate::Desktop) = 0.03 perl(Syntax::Highlight::Engine::Kate::Diff) = 0.03 perl(Syntax::Highlight::Engine::Kate::Doxygen) = 0.03 perl(Syntax::Highlight::Engine::Kate::E_Language) = 0.03 perl(Syntax::Highlight::Engine::Kate::Eiffel) = 0.03 perl(Syntax::Highlight::Engine::Kate::Email) = 0.03 perl(Syntax::Highlight::Engine::Kate::En_US) = 0.03 perl(Syntax::Highlight::Engine::Kate::Euphoria) = 0.03 perl(Syntax::Highlight::Engine::Kate::Ferite) = 0.03 perl(Syntax::Highlight::Engine::Kate::Fortran) = 0.03 perl(Syntax::Highlight::Engine::Kate::FourGL) = 0.03 perl(Syntax::Highlight::Engine::Kate::FourGLminusPER) = 0.03 perl(Syntax::Highlight::Engine::Kate::FreeBASIC) = 0.03 perl(Syntax::Highlight::Engine::Kate::GDL) = 0.03 perl(Syntax::Highlight::Engine::Kate::GLSL) = 0.03 perl(Syntax::Highlight::Engine::Kate::GNU_Assembler) = 0.03 perl(Syntax::Highlight::Engine::Kate::GNU_Gettext) = 0.03 perl(Syntax::Highlight::Engine::Kate::HTML) = 0.03 perl(Syntax::Highlight::Engine::Kate::Haskell) = 0.03 perl(Syntax::Highlight::Engine::Kate::IDL) = 0.03 perl(Syntax::Highlight::Engine::Kate::ILERPG) = 0.03 perl(Syntax::Highlight::Engine::Kate::INI_Files) = 0.03 perl(Syntax::Highlight::Engine::Kate::Inform) = 0.03 perl(Syntax::Highlight::Engine::Kate::Intel_x86_NASM) = 0.03 perl(Syntax::Highlight::Engine::Kate::JSP) = 0.03 perl(Syntax::Highlight::Engine::Kate::Java) = 0.03 perl(Syntax::Highlight::Engine::Kate::JavaScript) = 0.03 perl(Syntax::Highlight::Engine::Kate::JavaScript_PHP) = 0.03 perl(Syntax::Highlight::Engine::Kate::Javadoc) = 0.03 perl(Syntax::Highlight::Engine::Kate::KBasic) = 0.03 perl(Syntax::Highlight::Engine::Kate::Kate_File_Template) = 0.03 perl(Syntax::Highlight::Engine::Kate::LDIF) = 0.03 perl(Syntax::Highlight::Engine::Kate::LPC) = 0.03 perl(Syntax::Highlight::Engine::Kate::LaTeX) = 0.03 perl(Syntax::Highlight::Engine::Kate::Lex_Flex) = 0.03 perl(Syntax::Highlight::Engine::Kate::LilyPond) = 0.03 perl(Syntax::Highlight::Engine::Kate::Literate_Haskell) = 0.03 perl(Syntax::Highlight::Engine::Kate::Logtalk) = 0.03 perl(Syntax::Highlight::Engine::Kate::Lua) = 0.03 perl(Syntax::Highlight::Engine::Kate::M3U) = 0.03 perl(Syntax::Highlight::Engine::Kate::MABminusDB) = 0.03 perl(Syntax::Highlight::Engine::Kate::MIPS_Assembler) = 0.03 perl(Syntax::Highlight::Engine::Kate::Makefile) = 0.03 perl(Syntax::Highlight::Engine::Kate::Mason) = 0.03 perl(Syntax::Highlight::Engine::Kate::Matlab) = 0.03 perl(Syntax::Highlight::Engine::Kate::Modulaminus2) = 0.03 perl(Syntax::Highlight::Engine::Kate::Music_Publisher) = 0.03 perl(Syntax::Highlight::Engine::Kate::Nl) = 0.03 perl(Syntax::Highlight::Engine::Kate::Objective_Caml) = 0.03 perl(Syntax::Highlight::Engine::Kate::ObjectiveminusC) = 0.03 perl(Syntax::Highlight::Engine::Kate::Octave) = 0.03 perl(Syntax::Highlight::Engine::Kate::PHP_HTML) = 0.03 perl(Syntax::Highlight::Engine::Kate::PHP_PHP) = 0.03 perl(Syntax::Highlight::Engine::Kate::POVminusRay) = 0.03 perl(Syntax::Highlight::Engine::Kate::Pascal) = 0.03 perl(Syntax::Highlight::Engine::Kate::Perl) = 0.03 perl(Syntax::Highlight::Engine::Kate::PicAsm) = 0.03 perl(Syntax::Highlight::Engine::Kate::Pike) = 0.03 perl(Syntax::Highlight::Engine::Kate::PostScript) = 0.03 perl(Syntax::Highlight::Engine::Kate::Progress) = 0.03 perl(Syntax::Highlight::Engine::Kate::Prolog) = 0.03 perl(Syntax::Highlight::Engine::Kate::PureBasic) = 0.03 perl(Syntax::Highlight::Engine::Kate::Python) = 0.03 perl(Syntax::Highlight::Engine::Kate::Quake_Script) = 0.03 perl(Syntax::Highlight::Engine::Kate::REXX) = 0.03 perl(Syntax::Highlight::Engine::Kate::RPM_Spec) = 0.03 perl(Syntax::Highlight::Engine::Kate::RSI_IDL) = 0.03 perl(Syntax::Highlight::Engine::Kate::R_Script) = 0.03 perl(Syntax::Highlight::Engine::Kate::RenderMan_RIB) = 0.03 perl(Syntax::Highlight::Engine::Kate::Ruby) = 0.03 perl(Syntax::Highlight::Engine::Kate::SGML) = 0.03 perl(Syntax::Highlight::Engine::Kate::SML) = 0.03 perl(Syntax::Highlight::Engine::Kate::SQL) = 0.03 perl(Syntax::Highlight::Engine::Kate::SQL_MySQL) = 0.03 perl(Syntax::Highlight::Engine::Kate::SQL_PostgreSQL) = 0.03 perl(Syntax::Highlight::Engine::Kate::Sather) = 0.03 perl(Syntax::Highlight::Engine::Kate::Scheme) = 0.03 perl(Syntax::Highlight::Engine::Kate::Scilab) = 0.03 perl(Syntax::Highlight::Engine::Kate::Sieve) = 0.03 perl(Syntax::Highlight::Engine::Kate::Spice) = 0.03 perl(Syntax::Highlight::Engine::Kate::Stata) = 0.03 perl(Syntax::Highlight::Engine::Kate::TI_Basic) = 0.03 perl(Syntax::Highlight::Engine::Kate::TaskJuggler) = 0.03 perl(Syntax::Highlight::Engine::Kate::Tcl_Tk) = 0.03 perl(Syntax::Highlight::Engine::Kate::Template) = 0.03 perl(Syntax::Highlight::Engine::Kate::ToolKit) = 0.01 perl(Syntax::Highlight::Engine::Kate::Txt2tags) = 0.03 perl(Syntax::Highlight::Engine::Kate::UnrealScript) = 0.03 perl(Syntax::Highlight::Engine::Kate::VHDL) = 0.03 perl(Syntax::Highlight::Engine::Kate::VRML) = 0.03 perl(Syntax::Highlight::Engine::Kate::Velocity) = 0.03 perl(Syntax::Highlight::Engine::Kate::Verilog) = 0.03 perl(Syntax::Highlight::Engine::Kate::WINE_Config) = 0.03 perl(Syntax::Highlight::Engine::Kate::Wikimedia) = 0.03 perl(Syntax::Highlight::Engine::Kate::XHarbour) = 0.03 perl(Syntax::Highlight::Engine::Kate::XML) = 0.03 perl(Syntax::Highlight::Engine::Kate::XMLData) = 0.01 perl(Syntax::Highlight::Engine::Kate::XML_Debug) = 0.02 perl(Syntax::Highlight::Engine::Kate::Xorg_Configuration) = 0.03 perl(Syntax::Highlight::Engine::Kate::Xslt) = 0.03 perl(Syntax::Highlight::Engine::Kate::Yacas) = 0.03 perl(Syntax::Highlight::Engine::Kate::Yacc_Bison) = 0.03 Requires: perl(Carp) perl(Data::Dumper) perl(File::Basename) perl(Syntax::Highlight::Engine::Kate::AHDL) perl(Syntax::Highlight::Engine::Kate::ANSI_C89) perl(Syntax::Highlight::Engine::Kate::ASP) perl(Syntax::Highlight::Engine::Kate::AVR_Assembler) perl(Syntax::Highlight::Engine::Kate::AWK) perl(Syntax::Highlight::Engine::Kate::Ada) perl(Syntax::Highlight::Engine::Kate::Alerts) perl(Syntax::Highlight::Engine::Kate::Asm6502) perl(Syntax::Highlight::Engine::Kate::Bash) perl(Syntax::Highlight::Engine::Kate::BibTeX) perl(Syntax::Highlight::Engine::Kate::C) perl(Syntax::Highlight::Engine::Kate::CGiS) perl(Syntax::Highlight::Engine::Kate::CMake) perl(Syntax::Highlight::Engine::Kate::CSS) perl(Syntax::Highlight::Engine::Kate::CUE_Sheet) perl(Syntax::Highlight::Engine::Kate::Cdash) perl(Syntax::Highlight::Engine::Kate::Cg) perl(Syntax::Highlight::Engine::Kate::ChangeLog) perl(Syntax::Highlight::Engine::Kate::Cisco) perl(Syntax::Highlight::Engine::Kate::Clipper) perl(Syntax::Highlight::Engine::Kate::ColdFusion) perl(Syntax::Highlight::Engine::Kate::Common_Lisp) perl(Syntax::Highlight::Engine::Kate::ComponentminusPascal) perl(Syntax::Highlight::Engine::Kate::Cplusplus) perl(Syntax::Highlight::Engine::Kate::D) perl(Syntax::Highlight::Engine::Kate::Debian_Changelog) perl(Syntax::Highlight::Engine::Kate::Debian_Control) perl(Syntax::Highlight::Engine::Kate::Desktop) perl(Syntax::Highlight::Engine::Kate::Diff) perl(Syntax::Highlight::Engine::Kate::Doxygen) perl(Syntax::Highlight::Engine::Kate::E_Language) perl(Syntax::Highlight::Engine::Kate::Eiffel) perl(Syntax::Highlight::Engine::Kate::Euphoria) perl(Syntax::Highlight::Engine::Kate::Ferite) perl(Syntax::Highlight::Engine::Kate::Fortran) perl(Syntax::Highlight::Engine::Kate::FourGL) perl(Syntax::Highlight::Engine::Kate::FourGLminusPER) perl(Syntax::Highlight::Engine::Kate::GDL) perl(Syntax::Highlight::Engine::Kate::GLSL) perl(Syntax::Highlight::Engine::Kate::GNU_Assembler) perl(Syntax::Highlight::Engine::Kate::GNU_Gettext) perl(Syntax::Highlight::Engine::Kate::HTML) perl(Syntax::Highlight::Engine::Kate::Haskell) perl(Syntax::Highlight::Engine::Kate::IDL) perl(Syntax::Highlight::Engine::Kate::ILERPG) perl(Syntax::Highlight::Engine::Kate::INI_Files) perl(Syntax::Highlight::Engine::Kate::Inform) perl(Syntax::Highlight::Engine::Kate::Intel_x86_NASM) perl(Syntax::Highlight::Engine::Kate::JSP) perl(Syntax::Highlight::Engine::Kate::Java) perl(Syntax::Highlight::Engine::Kate::JavaScript) perl(Syntax::Highlight::Engine::Kate::Javadoc) perl(Syntax::Highlight::Engine::Kate::KBasic) perl(Syntax::Highlight::Engine::Kate::LDIF) perl(Syntax::Highlight::Engine::Kate::LPC) perl(Syntax::Highlight::Engine::Kate::LaTeX) perl(Syntax::Highlight::Engine::Kate::Lex_Flex) perl(Syntax::Highlight::Engine::Kate::LilyPond) perl(Syntax::Highlight::Engine::Kate::Literate_Haskell) perl(Syntax::Highlight::Engine::Kate::Lua) perl(Syntax::Highlight::Engine::Kate::MABminusDB) perl(Syntax::Highlight::Engine::Kate::MIPS_Assembler) perl(Syntax::Highlight::Engine::Kate::Makefile) perl(Syntax::Highlight::Engine::Kate::Mason) perl(Syntax::Highlight::Engine::Kate::Matlab) perl(Syntax::Highlight::Engine::Kate::Modulaminus2) perl(Syntax::Highlight::Engine::Kate::Music_Publisher) perl(Syntax::Highlight::Engine::Kate::Octave) perl(Syntax::Highlight::Engine::Kate::PHP_HTML) perl(Syntax::Highlight::Engine::Kate::PHP_PHP) perl(Syntax::Highlight::Engine::Kate::POVminusRay) perl(Syntax::Highlight::Engine::Kate::Pascal) perl(Syntax::Highlight::Engine::Kate::Perl) perl(Syntax::Highlight::Engine::Kate::PicAsm) perl(Syntax::Highlight::Engine::Kate::Pike) perl(Syntax::Highlight::Engine::Kate::PostScript) perl(Syntax::Highlight::Engine::Kate::Progress) perl(Syntax::Highlight::Engine::Kate::Prolog) perl(Syntax::Highlight::Engine::Kate::PureBasic) perl(Syntax::Highlight::Engine::Kate::Python) perl(Syntax::Highlight::Engine::Kate::Quake_Script) perl(Syntax::Highlight::Engine::Kate::REXX) perl(Syntax::Highlight::Engine::Kate::RPM_Spec) perl(Syntax::Highlight::Engine::Kate::RSI_IDL) perl(Syntax::Highlight::Engine::Kate::R_Script) perl(Syntax::Highlight::Engine::Kate::RenderMan_RIB) perl(Syntax::Highlight::Engine::Kate::Ruby) perl(Syntax::Highlight::Engine::Kate::SGML) perl(Syntax::Highlight::Engine::Kate::SML) perl(Syntax::Highlight::Engine::Kate::SQL) perl(Syntax::Highlight::Engine::Kate::SQL_MySQL) perl(Syntax::Highlight::Engine::Kate::SQL_PostgreSQL) perl(Syntax::Highlight::Engine::Kate::Sather) perl(Syntax::Highlight::Engine::Kate::Scheme) perl(Syntax::Highlight::Engine::Kate::Scilab) perl(Syntax::Highlight::Engine::Kate::Sieve) perl(Syntax::Highlight::Engine::Kate::Spice) perl(Syntax::Highlight::Engine::Kate::Stata) perl(Syntax::Highlight::Engine::Kate::TI_Basic) perl(Syntax::Highlight::Engine::Kate::Tcl_Tk) perl(Syntax::Highlight::Engine::Kate::Txt2tags) perl(Syntax::Highlight::Engine::Kate::UnrealScript) perl(Syntax::Highlight::Engine::Kate::VHDL) perl(Syntax::Highlight::Engine::Kate::VRML) perl(Syntax::Highlight::Engine::Kate::Velocity) perl(Syntax::Highlight::Engine::Kate::Verilog) perl(Syntax::Highlight::Engine::Kate::WINE_Config) perl(Syntax::Highlight::Engine::Kate::XHarbour) perl(Syntax::Highlight::Engine::Kate::XML) perl(Syntax::Highlight::Engine::Kate::XMLData) perl(Syntax::Highlight::Engine::Kate::XML_Debug) perl(Syntax::Highlight::Engine::Kate::Xslt) perl(Syntax::Highlight::Engine::Kate::Yacas) perl(Syntax::Highlight::Engine::Kate::Yacc_Bison) perl(XML::Dumper) perl(XML::TokeParser) perl(strict) perl(vars) perl(warnings) + Not a GUI application suggestions: 1)Remove BuildRequires: perl(XML::TokeParser) Its needed only at runtime and yum is resolving it APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review