Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498204 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #7 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-05-15 03:14:40 EDT --- Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1355744 + rpmlint output for SRPM and for RPM. perl-Wx-Perl-DataWalker.src: W: summary-not-capitalized implement subclass that shows relatively simple structure == >fix this + source files match upstream url d199c6a765168282c574c744bfdf707e10bb5549 Wx-Perl-DataWalker-0.02.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.04 usr 0.01 sys + 0.27 cusr 0.01 csys = 0.33 CPU) + Package perl-Wx-Perl-DataWalker-0.02-2.fc12.noarch => Provides: perl(Wx::Perl::DataWalker) = 0.02 perl(Wx::Perl::DataWalker::CurrentLevel) = 0.01 Requires: perl >= 0:5.008001 perl(Devel::Size) perl(Scalar::Util) perl(Wx) perl(Wx::Event) perl(Wx::Perl::DataWalker::CurrentLevel) perl(constant) perl(overload) perl(strict) perl(warnings) + Not a GUI application Suggestions: 1) fix rpmlint message APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review