Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: csound - music synthesis system https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203217 ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-08-31 18:38 EST ------- Right, it's happy in mock (i386) and I'm not overly concerned about the manual. Review time: Good : Consistent use of macros throughout the spec file Clear US-English builds cleanly in mock main package md5 matches upstream (cvs cannot be checked) Main package has docs, others report no docs (not worried) No problems with file permissions No dupes in the rpms Licences fine Doesn't have any locale stuff or desktop icon Compiles fine (x86) No ownership problems Needs work CVS archive doesn't match the guidelines (see http://fedoraproject.org/wiki/Packaging/NamingGuidelines#NonNumericRelease). It should reflect the date on which it was grabbed (so it really should be csound-manual-CVS20060816-disttag The files section can be globbed %{_bindir}/c* grabs all starting with c (etc) makes the spec file a lot simpler to read (IMO) Fix the CVS datestamp for the manual and I'm happy to let this one go in. I'd be happy if the file globbing in the spec file was done, but it's not a blocker if you don't -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review