Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500074 Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jochen@xxxxxxxxxxxxxxx --- Comment #1 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-05-10 15:02:13 EDT --- Good: + Basename of SPECE files matches with package name + Package contains valid License tag + License tag has LGPLv2+ as valid OSS license + Copyrith notes in source match with license tag + Package contains verbatin copy of the license text + Package has several sub packages + Sub package has proper BRs and Req. + consistently usage of rpm macros Bad: - Local build doesn't works - Koji build fails The readme told me, that we need swig, but build fails even if I have added swig as an BR. Please see. http://koji.fedoraproject.org/koji/taskinfo?taskID=1346448 - git-archive seem no to exist anymore, so please fix the comment how you have create th tar ball -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review