Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498748 Guido Grazioli <guido.grazioli@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |guido.grazioli@xxxxxxxxx --- Comment #1 from Guido Grazioli <guido.grazioli@xxxxxxxxx> 2009-05-10 05:14:20 EDT --- OK - rpmlint output 3 packages and 1 specfiles checked; 0 errors, 0 warnings. OK - The package must be named according to the Package Naming Guidelines. OK - The spec file name must match the base package %{name} OK - The package must meet the Packaging Guidelines OK - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc OK - The package must be licensed with a Fedora approved license and meet the Licensing Guidelines (license is GPLv3+) NA - Every binary RPM package which stores shared library files must call ldconfig in %post and %postun OK - The package MUST successfully compile and build koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1344884 OK - The spec file must be written in American English. OK - The spec file for the package MUST be legible. OK - The sources used to build the package must match the upstream source, as provided in the spec URL. bf2b5cd4ce82a9b851ed51529621d3eef6b09408 rpmdepsize-1.0.tar.gz NA - The spec file MUST handle locales properly (no translations) NA - package not relocatable OK - A package must own all directories that it creates OK - A Fedora package must not list a file more than once in the spec file's %files listings OK - Permissions on files must be set properly OK - Each package must have a %clean section OK - Each package must consistently use macros == you could use %{name} when removing execstack and in %files too OK - The package must contain code, or permissable content (no content) NA - Large documentation files must go in a -doc subpackage (no large doc) OK - If a package includes something as %doc, it must not affect the runtime of the application NA - Header files must be in a -devel package (no devel package) NA - Static libraries must be in a -static package (no static package) NA - Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' OK - Packages must NOT contain any .la libtool archives NEEDSWORK - Packages containing GUI applications MUST include a .desktop file == there's no desktop file OK - No file conflicts with other packages and no general names. OK - At the beginning of %install, each package MUST run rm -rf %{buildroot} OK - All filenames in rpm packages must be valid UTF-8 OK - The package does not yet exist in Fedora. The Review Request is not a duplicate. OK - %{?dist} tag is used in release Hello Jussi, if you add the desktop file i think we are done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review