Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499959 Emmanuel Seyman <emmanuel.seyman@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmanuel.seyman@club-intern | |et.fr --- Comment #1 from Emmanuel Seyman <emmanuel.seyman@xxxxxxxxxxxxxxxx> 2009-05-10 04:51:22 EDT --- Unofficial review: + package builds in mock (rawhide i586). x rpmlint is NOT silent for SRPM and for RPM. rpmlint redmine-0.8.3-5.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint redmine-0.8.3-5.fc11.noarch.rpm gives 124 errors and 1 warning. The errors are of the types: * htaccess-file * non-executable-script * script-without-shebang * version-control-internal-file * wrong-script-end-of-line-encoding * zero-length Please fix these or explain why they should be ignored. + source files match upstream url 52946a1b310e891da6613e8c7b429043 redmine-0.8.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. ? Spec file is legible. I'm unsure that "http://www.%{name}.org"; falls in the legible category. I'll let an official reviewer decide on this. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. Note that redmine seems to be licensed under GPLv2 or later while your spec file says "GPLv2". I'm guessing you should use "GPLv2+" + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. x Macro use appears rather consistent. Your %install reads: %{__rm} -rf %{buildroot} while your %clean uses: rm -rf %{buildroot} Please use one or the other but not both. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. x file permissions are appropriate. See rpmlint output. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review