Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499069 Jens Petersen <petersen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #12 from Jens Petersen <petersen@xxxxxxxxxx> 2009-05-10 03:06:53 EDT --- This is a simple packaging of macros.ghc which is currently bundled with the main large ghc package. Here is the review: +:ok, !:needs attention, NA: not applicable MUST Items: [+] MUST: rpmlint output [+] MUST: Package Naming Guidelines [+] MUST: spec file name must match base package %{name} [+] MUST: Packaging Guidelines. [+] MUST: Licensing Guidelines [+] MUST: License field in the package spec file must match actual license. [+] MUST: include license files in %doc if available in source [+] MUST: The spec file must be written in American English and be legible. [NA] MUST: source md5sum matches upstream release [+] MUST: must successfully compile and build into binary rpms on one main arch [NA] MUST: if necessary use ExcludeArch for other archs [NA] MUST: All build dependencies must be listed in BuildRequires [NA] MUST: use %find_lang macro for .po translations [+] MUST: A package must own all directories that it creates. [+] MUST: A package must not contain any duplicate files in the %files listing. [!] MUST: Permissions on files must be set properly. %config taken care of by patch 6 above [+] MUST: Each package must have a %clean section [+] MUST: Each package must consistently use macros [+] MUST: The package must contain code, or permissable content. [NA] MUST: Large documentation files should go in a doc subpackage. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: All filenames in rpm packages must be valid UTF-8. SHOULD Items: [NA] SHOULD: If scriptlets are used, those scriptlets must be sane. Please apply the attached fix for the rpmlint warning. Package is APPROVED by petersen -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review