Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491317 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |erik-fedora@xxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |erik-fedora@xxxxxxxxxxxxxxx --- Comment #12 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> 2009-05-09 14:15:17 EDT --- Okay, I'll continue the review. - The .spec file contains a lot of commented out parts. You might want to remove these for readability - The %{_mingw32_configure} call contains --with-package-name='Fedora Core gstreamer package'. Fedora Core isn't used anymore these days, so you might want to use just plain 'Fedora' here (without the 'Core'). - When performing make, you've added -D__MSVCRT_VERSION__=0x0601 to the CFLAGS. You might want to put a reference to the discussion about this in there as a comment: http://www.mail-archive.com/fedora-mingw@xxxxxxxxxxxxxxxxxxxxxxx/msg00741.html - Isn't it possible to set the -D__MSVCRT_VERSION__=0x0601 in the %configure phase? This is recommended to minimize the chance of side-effects - At line 116 there's the comment '# Install doc temporarily in order to be included later by rpm'. This is confusing as the next line contains a regular 'make install' command - The libtool .la files don't need to be removed as they're required to compile applications/other libraries with want to link against gstreamer - You might want to put the .a files (static libraries) in a seperate -static subpackage - Why is an empty cache directory created in the %install phase? It isn't being used elsewhere in the .spec file - Why are the binaries split across two packages? - Why is the %defattr line at line 162 commented out ? - The include files and pkgconfig files are placed in the 'tools' subpackage, while they should be in the main package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review