Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499409 --- Comment #6 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-05-09 09:20:22 EDT --- Oh, still a few things to fix: - Source url is incorrect: http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net Also, you might want to use %{version} in the Source URL line, so that you don't have to change the version in multiple locations (you might end up building an old version). - I don't think the explicit Java version is necessary: 1.4.2 is quite old and is found on every distribution. (In reply to comment #5) > > Because the Fedora Java Packaging Guidelines say so; JPackage guidelines have > > no say on this :) > > Ok i found the thread in the ml and it was fairly convincing. Which mailing list? > The wiki should be fixed though, because the ant template suggests: > > %install > rm -rf $RPM_BUILD_ROOT > mkdir -p $RPM_BUILD_ROOT%{_javadir} > cp -p [build path to jar] \ > $RPM_BUILD_ROOT%{_javadir}/%{name}-%{version}.jar > > Can i do that or i need to ask someone to check it? I wouldn't touch it since it's a guideline page that has been approved by FESCo. I'll send a message about it to the packaging list. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review